crates/pet-fs/src/path.rs:82

• The comment states that GetLongPathNameW "may add \?\ prefix in some cases" but according to Microsoft documentation, GetLongPathNameW does not add the \?\ prefix - that's added by GetFullPathNameW or by the application itself. GetLongPathNameW typically removes the \?\ prefix if present. This comment may be misleading. Consider clarifying that this check handles cases where the path was already normalized or converted elsewhere, or if this is based on observed behavior, add a note about the specific cases where this occurs.

    // Remove UNC prefix if original path didn't have it
    // GetLongPathNameW may add \\?\ prefix in some cases

crates/pet-fs/src/path.rs:10

• The comment says GetLongPathNameW "preserves junction paths" but this might be slightly misleading. GetLongPathNameW doesn't specifically preserve junctions - it simply doesn't resolve them, whereas canonicalize does. The distinction is subtle but important. Consider rephrasing to "GetLongPathNameW normalizes case but does not resolve junctions/symlinks (unlike fs::canonicalize)" to be more precise about the behavior.

// Uses GetLongPathNameW which normalizes case but preserves junction paths.

crates/pet-fs/src/path.rs:342

• There is no test coverage for network UNC paths (e.g., "\server\share\path"). These paths have different characteristics than local drive paths and may behave differently with GetLongPathNameW. The trailing slash removal logic (lines 90-92) may also be incorrect for these paths. Consider adding test coverage for network paths to ensure they are handled correctly.

    #[test]
    #[cfg(windows)]
    fn test_norm_case_windows_normalizes_slashes() {
        // norm_case should convert forward slashes to backslashes (like canonicalize did)
        let path_with_forward_slashes = PathBuf::from("C:/Windows/System32");
        let result = norm_case(&path_with_forward_slashes);
        assert!(
            !result.to_string_lossy().contains('/'),
            "Should convert forward slashes to backslashes, got: {:?}",
            result
        );
        assert!(
            result.to_string_lossy().contains('\\'),
            "Should have backslashes, got: {:?}",
            result
        );
    }
}

crates/pet-fs/src/path.rs:79

• Using to_string_lossy().to_string() here may lose information from the OsString if it contains invalid UTF-8 sequences. This is the second conversion that could lose data (first was on line 46). While Windows paths are typically valid Unicode, this double conversion increases the risk of data loss. Consider working with the OsString directly or using methods that preserve the original bytes.

    let mut result_str = os_string.to_string_lossy().to_string();